Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Fixes installation when using Herd #726

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

nunomaduro
Copy link
Member

This pull request fixes the installation of Octane (RoadRunner) when using something like Herd.

Before:

 Octane requires "spiral/roadrunner-http:^3.0.1" and "spiral/roadrunner-cli:^2.5.0". Do you wish to install them as a dependencies? (yes/no) [no]:
 > yes

Could not open input file: /Users/nunomaduro/Library/Application

After:

 Octane requires "spiral/roadrunner-http:^3.0.1" and "spiral/roadrunner-cli:^2.5.0". Do you wish to install them as a dependencies? (yes/no) [no]:
 > yes

./composer.json has been updated
Running composer update spiral/roadrunner-http spiral/roadrunner-cli --with-all-dependencies
Loading composer repositories with package information
...

@nunomaduro nunomaduro requested a review from taylorotwell August 2, 2023 16:35
@taylorotwell taylorotwell merged commit 217e93a into 2.x Aug 2, 2023
@taylorotwell taylorotwell deleted the fix/installation-when-using-herd branch August 2, 2023 18:05
@bnzo
Copy link

bnzo commented Aug 27, 2023

@nunomaduro I just saw your exchange here: roadrunner-server/roadrunner#1667

Would it be a solution to switch back to the php alias? As it was here: 5b52910

Maybe only use the php alias by checking if herd is installed as herd is setting up automatically the alias in the .zshrc file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants