Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Adds support for multiple FrankenPHP Octane instances #777

Merged
merged 5 commits into from
Dec 20, 2023
Merged

[2.x] Adds support for multiple FrankenPHP Octane instances #777

merged 5 commits into from
Dec 20, 2023

Conversation

nunomaduro
Copy link
Member

This pull request adds support for multiple FrankenPHP Octane instances.

@nunomaduro nunomaduro marked this pull request as ready for review December 20, 2023 13:44
dunglas
dunglas reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Commands/StartFrankenPhpCommand.php Outdated Show resolved Hide resolved
@taylorotwell taylorotwell merged commit 42ce8da into 2.x Dec 20, 2023
10 checks passed
@taylorotwell taylorotwell deleted the feat/multiple-franken-processes branch December 20, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas left review comments

@taylorotwell taylorotwell Awaiting requested review from taylorotwell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nunomaduro @dunglas @taylorotwell