Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrankenPHP: Allow running Octane without artisan command #968

Conversation

AlliBalliBaba
Copy link
Contributor

@AlliBalliBaba AlliBalliBaba commented Nov 23, 2024

This PR is the minimum required to run Octane without pcntl and the artisan octane wrapper process.

Through a discussion in the FrankenPHP repo we realized that when working with a Laravel app that was embedded as a binary, the embedded repository path gets apparently lost along the way, preventing worker mode from working properly.

One way of circumventing this is by starting the process directly through an embedded Caddyfile with frankenphp run or frankenphp php-server. This PR sets sensible defaults for APP_BASE_PATH, APP_PUBLIC_PATH and MAX_REQUESTS, therefore allowing to run the frankenphp-worker.php script independently from php artisan octane:start.

This will not affect the current behavior for users using php artisan octane:start or php artisan octane:frankenphp.

@taylorotwell taylorotwell merged commit b8b11ef into laravel:2.x Nov 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants