FrankenPHP: Allow running Octane without artisan command #968
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the minimum required to run Octane without
pcntl
and theartisan octane
wrapper process.Through a discussion in the FrankenPHP repo we realized that when working with a Laravel app that was embedded as a binary, the embedded repository path gets apparently lost along the way, preventing worker mode from working properly.
One way of circumventing this is by starting the process directly through an embedded Caddyfile with
frankenphp run
orfrankenphp php-server
. This PR sets sensible defaults for APP_BASE_PATH, APP_PUBLIC_PATH and MAX_REQUESTS, therefore allowing to run thefrankenphp-worker.php
script independently fromphp artisan octane:start
.This will not affect the current behavior for users using
php artisan octane:start
orphp artisan octane:frankenphp
.