Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Cast returned client identifier value to string #1091

Conversation

strongholdmedia
Copy link
Contributor

Fixes #1089.

Will benefit anyone who wishes to switch to native prepared statements for performance or other reasons.

Since it should be 100% backwards compatible, please let me know what kinds of tests would one need for such cases.

@strongholdmedia
Copy link
Contributor Author

As a side note, please note that I removed the entity trait reference to prevent future ambiguity.
This is due to it has an impedance with the client interface.
Whilst EntityTrait has a type hint of mixed for all entities, ClientInterface suggests identifiers should be strings outright.

If this is something that is problematic, please let me know. Doing so would not cause any problems in execution, but may fail phpstan checks later on when trait support will be sufficiently advanced. :)

@driesvints driesvints changed the title Cast returned client identifier value to string [7.x] Cast returned client identifier value to string Oct 3, 2019
@taylorotwell taylorotwell merged commit 5835940 into laravel:7.0 Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid request error with MySQL & emulated prepares OFF
3 participants