[10.x] Fix migrations for Laravel 9.x #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ricky-perchpeek. I think we can make an exception here. I've released v10.4.2 with this for you 👍 |
|
This is awesome! Thank you @driesvints! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm fairly sure this won't get merged, and I'm cool with that... but encountered an issue today where recent changes made to Laravel 9 have broken in memory tests when using anonymous migrations written in this style, as reported here in Telescope.
I've aimed this PR at Passport v10, which is otherwise compatible with Laravel 9, and attempted to write it in a similar style to Nuno's fix for the aforementioend Telescope issue... but also know that a better fix is just to upgrade to Passport v11.
Hope this helps... and, even if it doesn't get merged, I hope it helps anyone else who bumps into the same problem.
✌️