[1.x] Ensure values returns feature name #107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #106
There is an inconsistency when retrieving a list of specific values with Pennant.
When you have a class-based feature that has a name, e.g,
$name = 'my-feature';
, theFeature::values
function will inconstantly return the name and the feature's classname.Given the following class...
We see the inconsistency in the last call to
Feature::values
:Given the main usecase for the
Feature::values
function is to pass features to the front end......and the main usecase for the
$name
is to decouple the database and front end from the back end implementation, this feels like a bug that we should address.