[1.x] Ensure values returns feature name

[timacdonald]

fixes #106

There is an inconsistency when retrieving a list of specific values with Pennant.

When you have a class-based feature that has a name, e.g, $name = 'my-feature';, the Feature::values function will inconstantly return the name and the feature's classname.

Given the following class...

namespace App\Features;

class MyFeature
{
    public $name = 'my-feature';

    // ...
}

We see the inconsistency in the last call to Feature::values:

Feature::all();

// ✅
// 
// [
//     'my-feature' => true,
// ]

Feature::values(['my-feature']);

// ✅
// 
// [
//     'my-feature' => true,
// ]

Feature::values([Myfeature::class]);

// ❌
// 
// [
//     'App\Features\MyFeature' => true,
// ]

Given the main usecase for the Feature::values function is to pass features to the front end...

<script>
const features = @js(Feature::values(['feature-1', 'feature-2']))
</script>

<div v-if="features['feature-1']>
    <!-- ... -->
</div>

...and the main usecase for the $name is to decouple the database and front end from the back end implementation, this feels like a bug that we should address.

[github-actions]

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

[timacdonald]

As the resolveFeature function is protected, I have introduced a new method for this so we didn't have to introduce a breaking change by changing the visibility.

Also, name is a much nicer public facing method name.

We use this internally, but it can also be useful in user-land code.

Feature::name(FeatureWithoutNameProperty::class);
// App\Features\FeatureWithoutNameProperty
Feature::name(FeatureWithNameProperty::class);
// 'feature-with-name-property'