Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for plain objects as scope #98

Closed
wants to merge 1 commit into from

Conversation

jkatruska
Copy link

Fixes #97

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@jkatruska
Copy link
Author

Hi @taylorotwell, thank you for your response.

I still think this is a bug because according to the documentation Pennant's built-in array and database storage drivers know how to properly store scope identifiers for all PHP data types as well as Eloquent models. you should be able to use any data type as a scope, but as I mentioned in issue #97, only null|int|string|Model are valid scopes.

@timacdonald
Copy link
Member

Please see my comment: #97 (comment)

@denisvanmorgan
Copy link

hi, any chance this gets more attention? IMO the proposed solution is more robust, without need to fetch user multiple times if you don't use eloquent model. not every app is necessarily using DB, e.g. BFF in microservice architecture, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use non-eloquent objects as scope
4 participants