We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.9.0
8.2.0
Fixing indentation is broken in the Laravel preset since #166 was merged.
This is caused by the statement_indentation rule not being enabled in the Laravel preset.
Before the above PR was merged, the rule was being run by the braces rule.
Resolution: statement_indentation rule should be enabled in the Laravel preset. Sending a PR.
Example on a new laravel project, edited app/Providers/AppServiceProvider.php:
app/Providers/AppServiceProvider.php
➜ pint-test git:(master) ✗ cat app/Providers/AppServiceProvider.php <?php namespace App\Providers; use Illuminate\Support\ServiceProvider; class AppServiceProvider extends ServiceProvider { /** * Register any application services. */ public function register(): void { // } /** * Bootstrap any application services. */ public function boot(): void { // } } ➜ pint-test git:(master) ✗ ./vendor/bin/pint --version Pint 1.9.0 ➜ pint-test git:(master) ✗ ./vendor/bin/pint app/Providers/AppServiceProvider.php . ───────────────────────────────────────────────────────────────────────────────── Laravel PASS ......................................................................... 1 file
The text was updated successfully, but these errors were encountered:
Enable statement_indentation rule in Laravel preset
e34b462
Fixes laravel#177
Ping @Jubeki
Sorry, something went wrong.
Yeah that seems to fix it (see pint.json below).
I assumed there was a reason statement_indentation was already disabled beforehand and so I didn't touch it further.
{ "preset": "laravel", "rules": { "statement_indentation": true } }
Enable statement_indentation rule in Laravel preset (#178)
b4dcb7c
Fixes #177
Successfully merging a pull request may close this issue.
Pint Version
1.9.0
PHP Version
8.2.0
Description
Fixing indentation is broken in the Laravel preset since #166 was merged.
This is caused by the statement_indentation rule not being enabled in the Laravel preset.
Before the above PR was merged, the rule was being run by the braces rule.
Resolution: statement_indentation rule should be enabled in the Laravel preset. Sending a PR.
Steps To Reproduce
Example on a new laravel project, edited
app/Providers/AppServiceProvider.php
:The text was updated successfully, but these errors were encountered: