[Feature] Automatic validation option upon toggling multi-select prompts #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added an argument and a property "validateOnToggle" to MultiSelectPrompt that defaults to false
- If set to true, `validated` property gets set to true upon `toggleHighlight`; which triggers validation
- Wrote a test for it
- Ensured everything passes
I found this to be valuable and essential for the next PR, which is about introducing re-evaluated and cached options closure... Basically, what I was a bit confused aboutu in #116 .
If you like it, should I do the docs?
|
Hey @GoodM4ven, thanks for your PR! I'm not sure it's worth adding an additional function parameter for this. I'd need to see some compelling use cases or multiple people experiencing an issue with the current behaviour. Just to explain the reasoning behind the current behaviour, the delayed validation is intended to prevent an error message from being displayed before the user has had a chance to finish their input. This is primarily for text-based inputs where a user may be part-way through typing an email address. It also applies with multi-selects where the rule may be that they need to select a minimum number of options, and we don't want to display an error when they've chosen only one if they were already planning on selecting more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validatedproperty gets set to true upontoggleHighlight; which triggers validationI found this to be cool when it's accompanied with the next PR, which is about introducing re-evaluated and cached options closure; resulting in a reactive experience... Basically, it's what I was a bit confused about in #116 .
If you like it, should I do the docs?