Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for additional keys #140

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

ProjektGopher
Copy link
Contributor

@ProjektGopher ProjektGopher commented Apr 26, 2024

This narrowly targeted PR adds support for the ESC key, as well as shift + up and shift + down.

This may allow new prompts to be backed out of, or scrolled through more quickly.

@ProjektGopher ProjektGopher marked this pull request as draft April 26, 2024 22:29
@ProjektGopher
Copy link
Contributor Author

Marked as draft, but this is ready to go once reviewed.

@driesvints
Copy link
Member

@ProjektGopher draft PR's aren't reviewed. Please mark this as ready if you need one.

@ProjektGopher
Copy link
Contributor Author

Thx @driesvints, I thought marking as draft was part of Larave's process for this repo since my other PR got marked as draft without comment. Thx for the heads-up.

@ProjektGopher ProjektGopher marked this pull request as ready for review April 29, 2024 15:30
@taylorotwell
Copy link
Member

Adds support for the ESC key to do what action?

@taylorotwell taylorotwell merged commit 733c937 into laravel:main Apr 29, 2024
6 checks passed
@ProjektGopher
Copy link
Contributor Author

@taylorotwell I've got a prompt that I've built that allows you to hit escape in order to back out and return null if required is set to false.

@ProjektGopher ProjektGopher deleted the feature/add_keycodes branch April 29, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants