Add ability to specify character in pad function #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProjektGopher
force-pushed
the
feature/specify_char_in_pad
branch
from
1c3b6f8 to
684e2df
Compare
|
Marked as draft, but this is ready to go once reviewed. |
|
@ProjektGopher draft PR's aren't reviewed. Please mark this as ready if you need one. |
|
Thx @driesvints, I thought marking as draft was part of Larave's process for this repo since my other PR got marked as draft without comment. Thx for the heads-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to specify the character used to pad strings in the
DrawsBoxestrait. By using a default value of[SPACE]as an optional third parameter, this is fully backward compatible, and the test suite shows that no existing functionality is broken as a result.This will allow the
pad()method to be used withbox characters, or whatever else might be needed.