Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.3.0] Remove circular dependency on illuminate/collections #168

Merged
merged 22 commits into from
Sep 25, 2024

Conversation

jessarcher
Copy link
Member

This PR fixes a circular dependency issue between this package and https://github.com/laravel/framework by moving illuminate/collections to a dev dependency and removing all internal usage of Collections.

Collections remain supported as arguments to Prompt functions.

jessarcher and others added 14 commits September 24, 2024 09:39
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review September 24, 2024 23:12
@jessarcher jessarcher marked this pull request as draft September 24, 2024 23:41
@jessarcher jessarcher marked this pull request as ready for review September 25, 2024 02:20
@taylorotwell taylorotwell merged commit 5f99189 into main Sep 25, 2024
8 checks passed
@taylorotwell taylorotwell deleted the remove-collections-dep branch September 25, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants