Prevent C0 control codes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where pressing keys like
Ctrl+A,Ctrl+B, etc. while in a text field would capture non-printable control codes.In addition to returning these codes, it would also impact the box drawing because the characters would be counted for padding but not visually take up any space:
I previously maintained an ignore list to deal with the most common ones, but now that I better understand the problem, we can safely exclude any characters with an ordinal code point less than 32.
See https://en.wikipedia.org/wiki/C0_and_C1_control_codes and https://en.wikipedia.org/wiki/List_of_Unicode_characters
There are other potentially problematic control codes in the C1 range and elsewhere, but they're not easy to input in everyday use with the keyboard.