Add a default hint for the multiselect prompt
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
force-pushed
the
multiselect-space-hint
branch
from
cee78c1 to
cae11f5
Compare
|
This is great, thank you @jessarcher! As the author of #41, I agree this solves the problem I ran into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the
hintfeature introduced in #44 to add a default hint to themultiselectprompt, instructing users to use the space bar to select options. I went with the term "space bar" as it is the dominant wording used on Wikipedia.A few people have raised this issue specifically referring to the multi-select prompt used in the Laravel installer, which will be many people's first exposure to Prompts and Laravel. We could just add this hint to the multi-select prompts in the installer, but ultimately it seemed more user-friendly to make it the default. If someone does not want the hint, they would need to pass an empty string to the
hintargument.Fixes #41
Fixes #48