Make logo work in dark mode #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, all I did was add a border to the text in Figma and now it's rendering weirdly in GitHub, but is fine in Finder.
|
|
🤷♂️ I've no idea what's causing that. |
|
We previously had the outline, which I never liked the look of much on dark mode, until #97, where they made it responsive based on the system preference. It works well on Firefox/Linux, but it sounds like there are browsers where it doesn't?
|
|
@jessarcher it works for me, but I think the issue may be on GitHub mobile? #357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a white border around the "Laravel Pulse" text to make it visible in dark mode. We use the same technique on other packages.