Fix exception from missing import on select component #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
timacdonald
approved these changes
May 22, 2024
timacdonald
reviewed
May 22, 2024
Comment on lines
-15
to
+16
| {!! Laravel\Pulse\Facades\Pulse::css() !!} | ||
| {!! Pulse::css() !!} |
There was a problem hiding this comment.
Moving to imports to standardise how we reference classes in the views.
timacdonald
reviewed
May 22, 2024
Comment on lines
+23
to
+24
|
|
||
| AliasLoader::getInstance()->setAliases([]); |
There was a problem hiding this comment.
This ensures we don't rely on aliases across Pulse to help detect this in the future via the testsuite.
|
Will this be released as |
|
@RobertBoes made a quick release for this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I ran into this exception when upgrading to 1.2.0 today:
It looks to be a missing import on the
select.blade.phpcomponent, related to the change in #371.This PR just adds the import in (in a similar manner to the other blade files) so that the component can use the
Str::random()function.This is my first contribution to the Laravel ecosystem, so please let me know if there is anything missing or things I should consider for future PRs.
Thanks for making great software!