Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mariadb services #23

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Fix mariadb services #23

merged 3 commits into from
Jun 26, 2024

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Jun 26, 2024

Fixes laravel/sail#701

After renaming the sail services for mariadb in mariadb10 and mariadb the installation with the query parameter is currently not possible.

This PR allows mariadb10 and mariadb11, as well as replacing mariadb with mariadb11

@taylorotwell taylorotwell merged commit 905ac10 into laravel:master Jun 26, 2024
1 check passed
@Jubeki Jubeki deleted the fix-mariadb branch June 27, 2024 07:15
Jubeki added a commit to Jubeki/sail-server that referenced this pull request Jul 22, 2024
taylorotwell pushed a commit that referenced this pull request Jul 23, 2024
* Revert "Fix mariadb services (#23)"

This reverts commit 905ac10.

* Add typesense to tests again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I cannot create new app with mariadb service
2 participants