-
Notifications
You must be signed in to change notification settings - Fork 493
make sail script publishable #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sail script publishable #201
Conversation
42d43e0
to
0707584
Compare
```shell # publish only docker files artisan vendor:publish --tag=sail-docker # publish only bash-script artisan vendor:publish --tag=sail-bin # publish both artisan vendor:publish --tag=sail ```
Thanks @finagin, I think it will add more options to selectively publish desired files while keeping the old behavior. |
Separate groups for publish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this lines if you use alias sail='bash vendor/bin/sail'
run not published script
Yes, now you have to run './sail' to execute the published script. |
In #201 to tag `sail` added bash script and added separate tag `sail-docker` to publish only docker directory
This PR will allow developers to modify or add commands to the sail script.
If you decided to add a new custom service to the docker-compose.yml file and expose a command for this service via sail, you may add the command to the published sail script at the root of your app. For example, if you added a mongo service to your app you can make the mongo shell available by adding:
Currently, the script will be published by executing
sail artisan sail:publish
command, I was wondering if it should be published via its own command likesail artisan sail:publish-script
so that developers can publish it on demand.Also, The user doesn't have to register any alias command, the script will check if there is a file called
sail
at the root of the app, then it will execute it, otherwise, it will execute the original script in./vendor/bin/sail
.