[3.x] Fix bearer token format validation #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes validation for bearer tokens that contain model id (1|xxxxxxxx..).
If you alter this id, then server will return 500 error, because there is no format validation (yes, there is some validation regarding token expiration, and presence of the token at all, but that's not enough).
How to recreate
Just alter the id param for bearer token. Make it something not a valid integer.
This results 500 Server error response for any Sanctum-protected api endpoint.
(mssql server specific, but I think this can be DB-agnostic):
Expected value
401 Unauthorized HTTP status