-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting feature is missing in MeiliSearch Engine #572
Comments
This sounds like a feature request. We'd be happy to receive PR's. /cc @mmachatschek |
Hi @bedus-creation, this feature is plausable but was already tried to be implemented here #537 (See discussion) Maybe this is useful to the DatabaseEngine too and all engines could benefit from a generic solution. @driesvints |
@taylorotwell can we maybe revisit the PR from above that @mmachatschek linked to? |
The related pr was merged |
I think sort option is still missing in paginate function #537 |
@bedus-creation please send in a PR |
* Implements Meilisearch sort on paginate Fixes #572 * Fix test style ci * Fix formatting
Description:
MeiliSearch supports sorting feature out of the box after defining sortable parameters while indexing. The given
orderBy
method is supposed to work for sorting. Consider the following code.The above code should generate a query like in https://github.com/laravel/scout/blob/9.x/src/Engines/MeiliSearchEngine.php#L114
But the
sort
options is missing while performing the search.scout/src/Engines/MeiliSearchEngine.php
Lines 114 to 121 in 7811f6d
scout/src/Engines/MeiliSearchEngine.php
Lines 99 to 105 in 7811f6d
The text was updated successfully, but these errors were encountered: