Update builder class pagination methods to resolve LengthAwarePaginator using container #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address to fix #371. The LengthAwarePaginator was being instantiated directly in the pagination methods. This solution intends to use the container to resolve that class instead. This will give other container-based configurations a chance to hook into the paginators emitted by Scout in the same way that they can hook into Paginators emitted by Eloquent.
The specific use case that leads me down this path was an observation that the following Laravel-specific code was not affecting LengthAwarePaginators from Scout.
The test coverage for this class was pretty sparse. No existing tests break. I am happy to write some more specific tests to exercise the container work if needed.