[9.x] Support rename of filters to filter in meilisearch 0.21.x #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgeboot
force-pushed
the
meilisearch-0.21
branch
from
5757ce2 to
376dcd2
Compare
driesvints
reviewed
Aug 24, 2021
driesvints
reviewed
Aug 24, 2021
driesvints
changed the title
Remove composer
georgeboot
force-pushed
the
meilisearch-0.21
branch
from
b236475 to
8ea58cb
Compare
driesvints
reviewed
Aug 24, 2021
|
Only issue I can still see, is that we now check for the installed version of the SDK, not for the actual server version (which is technically more important). It is thus up to the user to match (major) versions. The only way to check actual server version is by doing an API call, which isn't really ideal. |
|
@georgeboot yeah indeed. But I think that's up to the user to match or up to the SDK, not for a third party library like Scout. |
This was referenced Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meilisearch 0.21.0 contains a breaking change regarding the
filtersattribute. It was renamed tofilterinstead.This PR addresses that by checking what version of the SDK was installed, and handling the attribute accordingly.
Not that user would need to manually add the attributes they want to filter on to the
filterableAttributessetting, they can not be used on any field any more as one could before version 0.21.