[9.x] - Collection Engine: add support for non-scalar values #528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Algolia and MeiliSearch engines both allow searchable data to be non-scalar values (e.g., an array of ingredients or genres).
The Collection engine, however, expects all values to be scalar, and during search, throws a
TypeError
if a model’stoSearchableArray()
returns any non-scalar key.This PR is a stupid-simple fix that just JSON-encodes non-scalar values on the theory that it will result in a string that
Str::contains()
will be able to inspect for the search term.