[10.x] Override attributesToRetrieve config to ensure search result is complete #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmachatschek
changed the title
mmachatschek
force-pushed
the
force_scoutkey_in_attributesToRetrieve
branch
from
0442bf5 to
4cce0c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #750
Fixes occasions with meilisearch where users can set options on the
Builderclass likeattributesToRetrievewhich would restrict the search engine to include the unique identifiers on the search result.Unfortunately if users customize their search engine calls this issue would still be possible as we have no control over the search result provided by the user.