Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh: add .profile sourcing #133

Merged
merged 1 commit into from
Dec 9, 2017
Merged

zsh: add .profile sourcing #133

merged 1 commit into from
Dec 9, 2017

Conversation

Artistan
Copy link
Contributor

@Artistan Artistan commented Dec 8, 2017

the ENV variables are not working for zsh when running php artisan ....
https://superuser.com/a/892248/168712
zsh will try to load .zprofile, not .profile. We can just source it and then both zsh and bash will work.

the ENV variables are not working for zsh when running `php artisan ....`
https://superuser.com/a/892248/168712
zsh will try to load .zprofile, not .profile.  We can just source it and then both zsh and bash will work.
@Artistan
Copy link
Contributor Author

Artistan commented Dec 8, 2017

homestead uses zsh now, and that does not source the .profile script that bash does by default. Without that sourced, the ENV variable is not set for the user.

Note, this maybe an issue with manual crons also. In this case you use crontab with -l (login) and -c (string exec) * * * * bash -l -c "php artisan --env=custom ..."

.profile sourcing details....
https://superuser.com/a/892248/168712
bash -l -c details...
https://stackoverflow.com/a/21895892/372215

@svpernova09 svpernova09 merged commit 976589a into laravel:master Dec 9, 2017
@svpernova09
Copy link
Contributor

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants