Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array to string conversion #838

Closed
finagin opened this issue Feb 27, 2020 · 1 comment
Closed

Array to string conversion #838

finagin opened this issue Feb 27, 2020 · 1 comment

Comments

@finagin
Copy link
Contributor

finagin commented Feb 27, 2020 •
edited
Loading

  • Telescope Version: 3.1.0
  • Laravel Version: 6.17.0
  • PHP Version: 7.3.11
  • Database Driver & Version:

Description:

\Laravel\Telescope\IncomingEntry::tags expect array of string like ['tag1', 'tag2'] but array_map in \Laravel\Telescope\Telescope::record returns array of array of string like [['tag1', 'tag2']]

Steps To Reproduce:

  1. Create user tags in \App\Providers\TelescopeServiceProvider::register with \Laravel\Telescope\Telescope::tag
  2. Enable strict mode for throw notice as exception
  3. Catch "Array to string conversion" exception
@finagin finagin mentioned this issue Feb 27, 2020
Merged
themsaid pushed a commit that referenced this issue Feb 28, 2020
@finagin
#838 Array to string conversion (#839)
ba5316b
@themsaid
Copy link
Member

Fixed in #839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@themsaid @finagin