Add http client request watcher #1073
Conversation
resources/views/layout.blade.php
Outdated
| <li class="nav-item"> | ||
| <router-link active-class="active" to="/client-requests" class="nav-link d-flex align-items-center"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20"> | ||
| <path d="M7 3H2v14h5V3zm2 0v14h9V3H9zM0 3c0-1.1.9-2 2-2h16a2 2 0 0 1 2 2v14a2 2 0 0 1-2 2H2a2 2 0 0 1-2-2V3zm3 1h3v2H3V4zm0 3h3v2H3V7zm0 3h3v2H3v-2z"/> |
There was a problem hiding this comment.
I replaced it with a globe icon from zondicons. (that is also the source of the other icons according to #679 (comment))
composer.json
Outdated
| @@ -16,6 +16,7 @@ | |||
| "require": { | |||
| "php": "^7.3|^8.0", | |||
| "ext-json": "*", | |||
| "guzzlehttp/guzzle": "^7.3", | |||
There was a problem hiding this comment.
I don't think Guzzle itself is required?
There was a problem hiding this comment.
Locally I needed to install guzzle to run the tests, but you are right that this should not be a requirement to install Telescope. I removed the dependency and I updated the "tests" github workflow to install the "guzzlehttp/guzzle" composer package before running the tests.
| { | ||
| parent::getEnvironmentSetUp($app); | ||
|
|
||
| if (! class_exists(\GuzzleHttp\Client::class)) { |
| @@ -39,7 +39,7 @@ jobs: | |||
|
|
|||
| - name: Install dependencies | |||
| run: | | |||
| composer require "illuminate/contracts=${{ matrix.laravel }}" --no-update | |||
| composer require "illuminate/contracts=${{ matrix.laravel }}" "guzzlehttp/guzzle" --no-update | |||
There was a problem hiding this comment.
Add this to the dev requirements instead please.
|
Hey @gdebrauwer, can you also send in a PR to document this? https://laravel.com/docs/8.x/telescope |
|
Yes of course! 👍 |
In Laravel 8.45.0 (laravel/framework#37572), events were introduced in the Http Client. I thought it would be nice to add a watcher for the Http Client, using these new events. This will make it easier to debug requests/responses of the Http Client.
In the detail view, you can see the request payload and response body, but also the headers of both the request and the response.
The request payload and headers are being filtered based on the
Telescope::$hiddenRequestParameters, similar to a regular Laravel request in Telescope.The request body is converted to json (just as as is the case with a regular Laravel request in Telescope). There is one limitation currently in case of a multipart request. If the request contains a file without a filename or headers, then that file will not be converted to a json object containing name and size and headers. Instead the full file content will still be included in the saved request payload. This is because I don't think there is a way to detect if "contents" in multipart item is a file or not.