Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fix for JobWatchers when the job payload is encrypted #1089

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Added a fix for JobWatchers when the job payload is encrypted #1089

merged 1 commit into from
Jul 9, 2021

Conversation

morloderex
Copy link
Contributor

Hey guys.

I have opened this pr because i encountered a problem when using the JobEncryption feature for a given job.

Telescope assumes the Job is already ready to be unserialized and does not handle encryption

The logic have i stolen from here:
https://github.com/laravel/framework/blob/108385b4f98cacfc1ef1d6e323f57b1c2df3180f/src/Illuminate/Queue/CallQueuedHandler.php#L86-L105

Therefore i have not provided any tests sense the logic is exactly the same apart from the container not being present on the instance itself.

Signed-off-by: Michael Lundbøl <michael.lundboel@gmail.com>
@taylorotwell
Copy link
Member

Were you able to confirm this fixes the issue on your Telescope installation?

@morloderex
Copy link
Contributor Author

morloderex commented Jul 8, 2021

Yes.

After adding this code to the watcher it was working as expected.

I can add a test case for it if it’s needed but as the code is the same as in the framework I feel like it’s testing the same thing twice.

@taylorotwell taylorotwell merged commit 4f613b1 into laravel:4.x Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants