Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix telescope.domain usage. #1123

Closed
wants to merge 1 commit into from
Closed

[3.x] Fix telescope.domain usage. #1123

wants to merge 1 commit into from

Conversation

finagin
Copy link
Contributor

@finagin finagin commented Sep 9, 2021

// config/telescope.php
return [
    'domain' => 'telescope.example.com',
    'path' => null,
];

If you use domain without path handlingApprovedRequest always return false because config('telescope.path').'*' is '*'
I propose check domain before check path.

}

return static::requestIsToApprovedDomain($app['request'])
|| static::requestIsToApprovedUri($app['request']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this an "or" condition?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because if this is a separate domain for telescope, we should not keep a record, if the domain is not separate, we check the paths

@taylorotwell
Copy link
Member

Only needs to be sent to current branch.

@finagin
Copy link
Contributor Author

finagin commented Sep 10, 2021

Only needs to be sent to current branch.

Hey @taylorotwell!
I ran into this problem on a project with laravel 6 and I need these changes there because we cannot update laravel yet.
These changes don't break anything

@driesvints
Copy link
Member

@finagin we only maintain the latest versions of our packages. Please upgrade to Laravel 8

@finagin
Copy link
Contributor Author

finagin commented Sep 10, 2021

@finagin we only maintain the latest versions of our packages. Please upgrade to Laravel 8

Laravel 6 is LTS right?
Branch telescope 3.x exists?
I think there is no problem to merge these changes

@driesvints
Copy link
Member

Laravel 6 is LTS but the first party packages aren't. You can find all that info in our support policy https://laravel.com/docs/8.x/releases#support-policy

@finagin
Copy link
Contributor Author

finagin commented Sep 10, 2021

Sorry, but then I don't understand why the 3.x branch is needed instead of 3.0? Here and at Horizon.
Tell me if it's not difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants