-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Fix telescope.domain
usage.
#1123
Conversation
} | ||
|
||
return static::requestIsToApprovedDomain($app['request']) | ||
|| static::requestIsToApprovedUri($app['request']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this an "or" condition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because if this is a separate domain for telescope, we should not keep a record, if the domain is not separate, we check the paths
Only needs to be sent to current branch. |
Hey @taylorotwell! |
@finagin we only maintain the latest versions of our packages. Please upgrade to Laravel 8 |
Laravel 6 is LTS right? |
Laravel 6 is LTS but the first party packages aren't. You can find all that info in our support policy https://laravel.com/docs/8.x/releases#support-policy |
Sorry, but then I don't understand why the 3.x branch is needed instead of 3.0? Here and at Horizon. |
If you use
domain
withoutpath
handlingApprovedRequest
always return false becauseconfig('telescope.path').'*'
is'*'
I propose check domain before check path.