Merge previously defined view data when building the view mailable data #1157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
In a project I manage, in which we use Telescope, we also have set up functionality to record any sent emails in the database using the
Illuminate\Mail\Mailable::buildViewDataUsing()
callback to pass the payload to theMessageSending
orMessageSent
events.When we have Telescope enabled, we find that this functionality breaks. This is because when Telescope starts it registers its own data to build up views with, and therefore overwrites our mailable data. For reference, this is where we define our own mailable data: https://github.com/bristol-su/portal-mail/blob/develop/src/MailServiceProvider.php#L89
This PR retrieves the current callback during the
start
function, and then if it isn't empty calls it when building View data and merges the result with Telescopes view data. This won't lead to any breaking changes since all the Telescope data is still present and prioritised over existing data, but will allow telescope users to still use the overriding view data feature.