Dont register redis watcher if the redis service is not bound into the container. #1259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing Telescope into a Laravel application which has opted out of Redis support by removing the
RedisServiceProvider
inapp.php
, aBindingResolutionException
is thrown during auto-discovery:This can be prevented by disabling the watcher using a .env value, or modifying the
telescope.php
config file, but a user who is installing Telescope for the first time wont expect to have to do such a thing to get it working.This pr makes the RedisWatcher register itself only when
redis
is bound into the application container to avoid this issue.Thanks for your time.