-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Multi-Tag Filtering and Search Functionality #1367
Conversation
Overall this looks good, but do have concern whether someone might already using |
Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
I'm not convinced that's the standard way to insert a tag, but how about this approach: |
I would be ok with that @Algeneralo We can also just let it roll like this for now. |
After making this change, I found that filtering by tag is extremely slow on a "large" database (I have a ~20GB separate Telescope database in MariaDB). The Telescope web interface hits a 504 error (after 1 minute of waiting) when filtering. I found that the database takes a long time to execute this query: select
*
from
`telescope_entries`
where
`type` = ?
and `uuid` in (
select
`entry_uuid`
from
`telescope_entries_tags`
where
`entry_uuid` in (
select
`entry_uuid`
from
`telescope_entries_tags`
where
`tag` in (?)
)
)
order by
`sequence` desc
limit
50 I believe the second select
*
from
`telescope_entries`
where
`type` = ?
and `uuid` in (
select
`entry_uuid`
from
`telescope_entries_tags`
where
`tag` in (?)
)
order by
`sequence` desc
limit
50 |
Description:
This Pull Request proposes the introduction of a significant enhancement to the existing search functionality in the Telescope. Specifically, it enables users to filter and search using multiple tags simultaneously for requests.
Why is this change necessary?
The current tag-based search and filter system only allows one tag per search. With the new multi-tag search and filtering, users can have more granular control over their search results, allowing for a more thorough and precise search experience.