Fix empty telescope path config in frontend #637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the frontend, which would break if the
config('telescope.path')
would be set to either empty or'/'
.Additionally, the configuration for
config('telescope.path')
andconfig('telescope.domain')
now supports the possibility to overwrite the values via the .env file.There are no frontend tests, so unfortunately I can not provide any tests. I click tested as good as I could.
Benefits
For environments (local and production) where you have a custom subdomain for telescope e.g.
telescope.example.local
you can now omit the prefix of the telescope routes by setting the .env variable optionTELESCOPE_PATH
to either empty or"/"
This makes telescope available via the following route
http://telescope.example.local/
instead ofhttp://telescope.example.local/telescope