Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty telescope path config in frontend #637

Merged
merged 2 commits into from
May 27, 2019
Merged

Fix empty telescope path config in frontend #637

merged 2 commits into from
May 27, 2019

Conversation

mmachatschek
Copy link
Contributor

This PR fixes the frontend, which would break if the config('telescope.path') would be set to either empty or '/'.

Additionally, the configuration for config('telescope.path') and config('telescope.domain') now supports the possibility to overwrite the values via the .env file.

There are no frontend tests, so unfortunately I can not provide any tests. I click tested as good as I could.

Benefits

For environments (local and production) where you have a custom subdomain for telescope e.g. telescope.example.local you can now omit the prefix of the telescope routes by setting the .env variable option TELESCOPE_PATH to either empty or "/"

This makes telescope available via the following route http://telescope.example.local/ instead of http://telescope.example.local/telescope

@taylorotwell
Copy link
Member

@themsaid can you review this?

@taylorotwell taylorotwell requested a review from themsaid May 27, 2019 13:29
@themsaid themsaid merged commit 896091c into laravel:2.0 May 27, 2019
@mmachatschek mmachatschek deleted the fix_telescope_path_in_view_router branch May 27, 2019 13:34
@themsaid
Copy link
Member

thanks :)

@mmachatschek
Copy link
Contributor Author

@themsaid You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants