Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app_name in dashboard #643

Merged
merged 3 commits into from
May 30, 2019
Merged

Add app_name in dashboard #643

merged 3 commits into from
May 30, 2019

Conversation

tomswinkels
Copy link
Contributor

We have a few project and every project has telescope. We have place the telescope monitor on a screen with a switch between all the telescopes but we now can't see witch telescope it is.

We think this is a good solution.

Add APP_NAME in dashboard
Change it to APP_NAME
@browner12
Copy link
Contributor

Environment variables should not be directly accessed in views. Please use a config variable instead.

@tomswinkels
Copy link
Contributor Author

@browner12 Taylor always say not to much config variables?

@browner12
Copy link
Contributor

If an application uses configuration caching, all calls to env() will return null.

https://laravel.com/docs/5.8/configuration#configuration-caching

@tomswinkels
Copy link
Contributor Author

Thnx @browner12. What is the best place? config/telescope.php?

@browner12
Copy link
Contributor

it already exists in config/app.php.

config('app.name').

Change to config file, not directly from the env.
@tomswinkels
Copy link
Contributor Author

You right. I have make a change in the pr.

@taylorotwell taylorotwell merged commit d9a47f2 into laravel:2.0 May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants