Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Avoiding to create guard #810

Merged
merged 1 commit into from
Jan 16, 2020
Merged

[2.x] Avoiding to create guard #810

merged 1 commit into from
Jan 16, 2020

Conversation

dkulyk
Copy link

@dkulyk dkulyk commented Jan 15, 2020

Sometimes guard is created when session not initialized yet.

@driesvints driesvints changed the title Avoiding to create guard [2.x] Avoiding to create guard Jan 15, 2020
@taylorotwell
Copy link
Member

Why does this matter?

@dkulyk
Copy link
Author

dkulyk commented Jan 15, 2020 •
edited
Loading

QueryWatcher try to make guard when session query executed and the guard not ready yet.

Request
 -> Make guard
  -> Make session store(stored to container)
   -> Query
    -> QueryWatcher
     -> Make guard(First guard not stored yet)
      ...

In some cases authentication is broken.

@taylorotwell taylorotwell merged commit ef6c64c into laravel:2.0 Jan 16, 2020
@dkulyk dkulyk deleted the patch-1 branch January 16, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkulyk @taylorotwell