Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix typed properties issues #879

Merged
merged 1 commit into from
Apr 20, 2020
Merged

[3.x] Fix typed properties issues #879

merged 1 commit into from
Apr 20, 2020

Conversation

lucasmichot
Copy link
Contributor

@lucasmichot lucasmichot commented Apr 20, 2020

Telescope Version: v3.1
Laravel Version: 6.18.0
PHP Version: 7.4.5


This PR solves the issue #781. This bug is still happening.

Note:

  • The value resolution function has been extracted in a dedicated method for better readability.
  • Some code credits also go to @golonix.

@driesvints driesvints changed the title Fix typed properties issues. [3.x] Fix typed properties issues Apr 20, 2020
@taylorotwell taylorotwell merged commit d4290e1 into laravel:3.x Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants