[4.x] Dump visibility toggling, search, etc. #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice if StyleCI could ignore that sfdump file so we can keep it as close to the original as possible. I'll try to figure that out. |
driesvints
changed the title
|
Or not. Thanks! |
|
@jasonvarga think it's best that we keep all code style consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hooks up the var dumper JS so that the toggles and search work.
Implements #636
The most valuable part of this IMO is that if you dump an object, your page isn't full of completely expanded objects. (Try dumping
app()a couple of times 😅 ) It's more consistent with what you'd see if you weren't using Telescope.Since Vue can't execute JS that's sent from the server and injected through
v-html, I've had to basically copy paste the var dumper JS.There's only a handful of modifications:
Sfdump = window.Sfdump || (function (doc) {, I'm putting the function into athis.sfDumpproperty on the Vue instance.letbeforeSearchStatehere to get around aReferenceError: assignment to undeclared variable SearchStateerror.let node;above this loop to get around aassignment to undeclared variable nodeerror.$optionshere, I've just hardcoded in the defaults.