Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Be able to specify only allowed paths #963

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Feature: Be able to specify only allowed paths #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions config/telescope.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,21 @@
Authorize::class,
],

/*
|--------------------------------------------------------------------------
| Allowed Paths
|--------------------------------------------------------------------------
|
| The following array lists the URI paths be watched by Telescope.
| NOTE: Specifying any paths in this list
| ignores all paths specified in 'ignore_paths' below.
|
*/

'only_allow_paths' => [
// 'api/*'
],

/*
|--------------------------------------------------------------------------
| Ignored Paths & Commands
Expand Down
12 changes: 11 additions & 1 deletion src/Telescope.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,17 @@ protected static function runningApprovedArtisanCommand($app)
*/
protected static function handlingApprovedRequest($app)
{
return ! $app->runningInConsole() && ! $app['request']->is(
if ($app->runningInConsole()) {
return false;
}

// Prioritize only_allow_paths if any are specified
$onlyAllowed = config('telescope.only_allow_paths', []);
if (! empty($onlyAllowed)) {
return $app['request']->is($onlyAllowed);
}

return ! $app['request']->is(
array_merge([
config('telescope.path').'*',
'telescope-api*',
Expand Down