Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Support php8 #977

Merged
merged 2 commits into from
Nov 2, 2020
Merged

[4.x] Support php8 #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c51284
Support PHP 8
mmachatschek Nov 2, 2020
4b43e69
Explicitly install required php modules
mmachatschek Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
fail-fast: true
matrix:
php: [7.3, 7.4]
php: [7.3, 7.4, 8.0]
laravel: [^8.0]

name: P${{ matrix.php }} - L${{ matrix.laravel }}
Expand All @@ -32,7 +32,7 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
extensions: dom, curl, libxml, mbstring, zip
extensions: curl, dom, gd, json, libxml, mbstring, zip
tools: composer:v2
coverage: none

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
}
],
"require": {
"php": "^7.3",
"php": "^7.3|^8.0",
"ext-json": "*",
"laravel/framework": "^8.2",
"symfony/var-dumper": "^5.0"
Expand Down
8 changes: 7 additions & 1 deletion tests/Watchers/ExceptionWatcherTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,13 @@ public function test_exception_watcher_register_entries_when_eval_failed()
$this->assertSame(ErrorException::class, $entry->content['class']);
$this->assertStringContainsString("eval()'d code", $entry->content['file']);
$this->assertSame(1, $entry->content['line']);
$this->assertSame('syntax error, unexpected end of file', $entry->content['message']);

if (\PHP_VERSION_ID < 80000) {
$this->assertSame('syntax error, unexpected end of file', $entry->content['message']);
} else {
$this->assertSame("Unclosed '('", $entry->content['message']);
}

$this->assertArrayHasKey('trace', $entry->content);
}
}
Expand Down