Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] PHP 8 Support #116

Merged
merged 2 commits into from
Oct 29, 2020
Merged

[2.x] PHP 8 Support #116

merged 2 commits into from
Oct 29, 2020

Conversation

driesvints
Copy link
Member

No description provided.

@driesvints driesvints marked this pull request as draft October 27, 2020 15:27
@GrahamCampbell GrahamCampbell marked this pull request as ready for review October 27, 2020 19:28
@GrahamCampbell
Copy link
Member

Ready, I think, now?

@driesvints
Copy link
Member Author

Need framework to be tagged first.

@driesvints driesvints marked this pull request as draft October 27, 2020 19:40
@GrahamCampbell
Copy link
Member

Tests pass without. :P

@driesvints
Copy link
Member Author

If we break something with the current fixes we're doing before we tag a new Laravel release I'd like to know about it ;)

@driesvints driesvints marked this pull request as ready for review October 29, 2020 12:50
@taylorotwell taylorotwell merged commit 24c7684 into 2.x Oct 29, 2020
@driesvints driesvints deleted the php8 branch October 29, 2020 12:52
taylorotwell pushed a commit that referenced this pull request Jan 13, 2021
@crynobone @driesvints @GrahamCampbell
Sync develop with code from 2.x branch (reserved all commits) (#120)
7a77fa0 
* Update .gitattributes

* Update .gitattributes

* [2.x] PHP 8 Support (#116)

* PHP 8 Support

* Bumped versions

Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>

* Update CHANGELOG.md

* Update phpunit.xml.dist

* Reapply commit 12c819b

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

Co-authored-by: Dries Vints <dries@vints.io>
Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driesvints @GrahamCampbell @taylorotwell