[2.x] Forward input options to psysh

[GrahamCampbell]

This PR forwards things like --no-ansi and -vv to psysh in the proper way, instead of ignoring them. Once this PR is merged, we can tag tinker v2.4.0.

// cc @bobthecow

[GrahamCampbell]

Heh, our tests shouldn't have passed. I guess we are not actually testing the tinker command. ;)

[GrahamCampbell]

Hmm, asking for verbose seems to just hang forever?

[bobthecow]

It's not hanging forever. It's just running as --quiet.

$input->getOption('verbose') is returning true, which PHP matches to anything truthy in this switch because PHP is awesome:

https://github.com/bobthecow/psysh/blob/5f97c26be75a2334a08530e7f99ead9cf0137a21/src/Configuration.php#L268

Apparently your verbose isn't compatible with my verbose. This seems at odds with what it spits out for --help on the command line:

Adding explicit handling for === true fixes it, and that seems like the reasonable answer, so I'll do that. But you should track down what's going on with your --verbose :)

[bobthecow]

Confirmed that the psysh change fixed running with -v.

[GrahamCampbell]

Oh, lol. Our verbose is just whatever symfony does as the default for commands.

[GrahamCampbell]

Is there a way for psysh to match up with those, or is it intentionally not defined like that?

[bobthecow]

PsySH does match up (with how Console\Application handles it, maybe something else does it differently?)

https://github.com/symfony/console/blob/619054da7627df1c2169c7aabe0df78f9320847c/Application.php#L869-L883

[bobthecow]

Oh cool. Symfony used the wrong definition for how they actually implemented the handling:

https://github.com/symfony/console/blob/619054da7627df1c2169c7aabe0df78f9320847c/Application.php#L975

[bobthecow]

Here we go. When the levels for --verbose flags were first added, it was defined as VALUE_OPTIONAL, as it needs to be for it to work with the values they're actually parsing:

symfony/console@039ba6f

But the same day, it was changed to VALUE_NONE with the commit message "Fix tests" 😬

symfony/console@841817b

… so the input definition has been broken the entire time, and the only reason it mostly works is Symfony doesn't actually use the input definition to parse the input for --verbose.

Given this, I think the answer is to stop trying to use getOption at all for verbosity, because using the bound input option will give the wrong answer.

[bobthecow]

All better! bobthecow/psysh@4884edf

[GrahamCampbell]

@bobthecow Thanks for this. The no-interaction flag doesn't seem to work, however:

[GrahamCampbell]

It looks like it does get set to disabled, but the configuration later doesn't get respected?

[driesvints]

Why would you use --no-interaction with Tinker?

[GrahamCampbell]

Why would you use --no-interaction with Tinker?

Well, all laravel's commands should respect the no interaction flag. In the case of the tinker command, instead of reading from the input "live", we'd just one-time read whatever was piped into from stdin, and execute it.

[GrahamCampbell]

I'd say this PR is ready for merge now. Handling of no-interaction is to be handled outside of the tinker package. We already forward the config properly.

[bobthecow]

It (probably) is doing "no interaction", you're just putting it in a weird place by not giving it anything to execute.

[GrahamCampbell]

It (probably) is doing "no interaction", you're just putting it in a weird place by not giving it anything to execute.

Surely psysh should either exit straight away with code 0 in that case, or it should throw an exception saying nothing to do?

[bobthecow]

It's a pretty straightforward change. I'm not entirely convinced it's what people will expect though :)

[GrahamCampbell]

Isn't the whole point of no-interaction is that the process will never wait for input?