Suggestion for update to AuthRouteMethods #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I appreciate all the work you and the team are doing. When upgrading from Laravel >= 5.7 and now 6.x to 7.x some of the methods and classes have changed. I kept getting a login and logout conflict with our web routes. I had to dig down and find this reference. The $options attribute is a great way to turn on/off routes but it seems a little incomplete. There are so many more suggestion dealing with following existing controller method naming conventions, should the options be in an auth configuration, etc. but wanted to focus on a low hanging fruit (this use case). Use case: Web route name "login" and "logout" is defined but still want to use auth routes "registration" and "reset". Was able to turn on/off everything except "login" route. I could see this being implemented in a minor version without backwards compatibility issues. Please consider. Thanks, Brant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I appreciate all the work you and the team are doing. When upgrading from Laravel >= 5.7 and now 6.x to 7.x some of the methods and classes have changed. I kept getting a login and logout conflict with our web routes. I had to dig down and find this reference. The $options attribute is a great way to turn on/off routes but it seems a little incomplete. There are so many more suggestion dealing with following existing controller method naming conventions, should the options be in an auth configuration, etc. but wanted to focus on a low hanging fruit (this use case).
Use case: Web route name "login" and "logout" is defined but still want to use auth routes "registration" and "reset". Was able to turn on/off everything except "login" and "logout" routes.
I could see this being implemented in a minor version without backwards compatibility issues. Please consider.
Thanks,
Brant