Change the specified time until re-authentication #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we the authentication timeout is configurable by the user, I don't think we should hard code "a few hours" here. Therefore, I now opted for "a certain amount of time".
Jhnbrn90
changed the title
driesvints
approved these changes
Oct 10, 2019
|
I just removed that whole line to judo the problem. I don't think it's super important to show that to the user. |
|
Also works 👍 |
Yeah, true 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the re-authentication timeout is configurable by the user (as described in laravel/framework#30214), I don't think we should hard code "a few hours" in the template.
Therefore, I now opted for "a certain amount of time", however let me know if you come across something more suitable.