-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update valet.sock
to be a symlink to an existing valet{version}.sock
file
#1201
Conversation
I haven't tested this yet. Will test before asking for review. |
valet.sock
to be a symlink to an existing valet{version}.sock filevalet.sock
to be a symlink to an existing valet{version}.sock
file
Handle "php@8.1" Simplify the entire method into one block Co-Authored-By: Nathan Morgan <nathan@fuelingtheweb.com>
…to mes/symlink-valet-socks
On both of my machines, the first time I ran The symlink only worked after I ran |
I'm also wondering... do we even need a symlink? It's a socket.. there may not actually be anything fancy going on here. It may just need a file to exist, in which case we could just delete the file and make a new one.. not even worry about symlinking? |
Add "secured" command
Current thinking about the symlink situation: If PHP8.0 is our primary version of PHP that's running They'll be pointing to different socket files that are both intending to represent the same PHP connection |
- Fix the isolated directories test given new table shape - Updated useVersion test to no longer hit the real filesystem Co-Authored-By: Jacob Baker-Kretzmar <18192441+bakerkretzmar@users.noreply.github.com>
Looks like |
…to mes/symlink-valet-socks
Co-Authored-By: Jacob Baker-Kretzmar <18192441+bakerkretzmar@users.noreply.github.com>
…ng PHP-FPM Co-Authored-By: Jacob Baker-Kretzmar <18192441+bakerkretzmar@users.noreply.github.com>
Solved this problem: #1201 (comment) I think at this point this PR is ready for review. |
Co-Authored-By: Jacob Baker-Kretzmar <18192441+bakerkretzmar@users.noreply.github.com>
This is 🔥! Won't pretend to know the ins-and-outs of how this works, but how hard would it be to add a CLI util to access that running PHP version? (Thinking along the lines of |
@shengslogar that's coming soon! checkout #1216
|
This PR modifies #1198, which is an update of #1192.
In #1192/#1198,
valet.sock
is always used by the global Valet PHP version, and then Valet sets upvalet80.sock
etc. for versions of PHP that aren't used globally but are used by isolated sites.This PR makes it so that every PHP version used by Valet, global or not, sets up a
valet{version}.sock
file, and the global version is set by simply symlink-ingvalet.sock
to the version-specific.sock
file.This PR:
normalizePhpVersion
with a regex from @fuelingtheweb; again should've just applied to Multiple/Parallel PHP Version Support for Valet #1192Bugs in testing:
valet.sock
disappear twice in the middle of my testing, which broke all sites. Re-runningvalet install
fixed it but I'm not sure what deleted it in the first place. I'll try to keep testing.