-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow start/restart/stop single service #874
Conversation
While my initial reaction to this was that it's not needed, I have found myself reaching for it several times in the past couple weeks. While I'm not a fan of the duplicate code it adds, it's not unbearable (and Valet already does some duplicate-code anyway, and this PR is correctly following the existing patterns in Valet). So, I'm okay with this one. 👍 |
Thanks for your comment. I hate duplicate code too. but as the file is too small and it's not too complicated with repeated lines I think it's okay to have it like the PR now as it follows the already used pattern in Valet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! A few requests
Hey @mattstauffer , thanks for the review. I've fixed all style issues. |
Co-Authored-By: Matt Stauffer <mattstauffer@users.noreply.github.com>
Sometimes all we just need is to restart nginx or php-fpm during development. so having a way to restart a specific service saves some time instead of waiting for dns-masq, php and nginx to restart