Abstract the key to easier override #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spoke with Joe about this idea via email. We need the ability to change the key in our app. Specifically because we a prefix in `config/filesystems.php` and use the same bucket across multiple staging environments. Per the discussion we would need to override the controller and customize it ourselves. It would be helpful if the key was abstracted so we didn't have to duplicate the entire logic in `store`
joedixon
pushed a commit
that referenced
this pull request
Aug 10, 2023
* Abstract the key to easier override Spoke with Joe about this idea via email. We need the ability to change the key in our app. Specifically because we a prefix in `config/filesystems.php` and use the same bucket across multiple staging environments. Per the discussion we would need to override the controller and customize it ourselves. It would be helpful if the key was abstracted so we didn't have to duplicate the entire logic in `store` * Update SignedStorageUrlController.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spoke with Joe about this idea via email.
We need the ability to change the key in our app because we use a root prefix in
config/filesystems.phpand use the same bucket across multiple staging environments.Per the discussion we would need to override the controller and customize it ourselves.
It would be helpful if the key was abstracted so we didn't have to duplicate the entire logic in
store