[2.0] Fixes streamed responses when using Octane #159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Octane of Vapor and returning a
StreamedResponse
such asStorage::download('my-file.png');
, the file is downloaded with no content.The following code is the issue:
Calling
getContent()
on aStreamedResponse
returnsfalse
and so we end up with a file with no content.With Lambda, we can't stream directly to the client. Instead, this PR captures the content from the stream and returns it.