Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide users away from attempting to load the dev server url to access site #40

Closed
hailwood opened this issue Jun 29, 2022 · 4 comments · Fixed by #57
Closed

Guide users away from attempting to load the dev server url to access site #40

hailwood opened this issue Jun 29, 2022 · 4 comments · Fixed by #57

Comments

@hailwood
Copy link
Contributor

Right now we're getting a few comments on the Laravel PR saying users can't load the page.
What's happening is they're attempting to load the devserver url (http://localhost:3000) and expecting it to load the site with HMR enabled.

I suggest we update the output the laravel plugin adds to make it clear that the site should still be loaded via the app url as I imagine for the few people that have logged an issue, many more have run into it without commenting.

I'm also wondering if it's related to the docs note that suggests loading the dev server url to accept the certificate warnings and people getting confused?

I'm not sure of the wording hence doing an issue instead of a PR.

Open {APP_URL} to enjoy your hot module reloading site powered by vite.

@jessarcher
Copy link
Member

jessarcher commented Jun 29, 2022

Thanks for the suggestion @hailwood! I've noticed this as well and was worried about it given how prominently Vite displays that URL. I'd hoped outputting our own Laravel section below, with the APP_URL would make it clearer, but we may need to be more explicit as you've suggested. Mix never output its URL so it avoided the confusion, but I do like being able to see it, especially with Vite's ability to find an available port if the default is in use.

I'll have a chat with the team and see what we can come up with.

For reference, this is the screen we're talking about:

image

We currently don't have any way to control what Vite outputs at the top, or the order of what is output. I can chat with the Vite team about it though.

@Koykoy200078
Copy link

same issue :<

@jessarcher
Copy link
Member

Thanks for recommending this @hailwood! I think #57 addresses this quite nicely. I'm still open to customising the initial console output, but at this stage, I can't think of anything that fits in with the existing Vite output. We will revisit this with Vite 3 as they've tweaked their output a little.

@ceres-tamle
Copy link

Your backend runs via:

php artisan serve

and your frontend runs via:

npm run dev

You probably should be running both when developing the app.
https://laravel.io/index.php/forum/laravel-breeze-host-refused-to-connect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants