-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help users that visit the Vite dev server directly #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
force-pushed
the
dev-server-index-help
branch
from
July 3, 2022 06:36
0bcbf9d
to
deb9374
Compare
jessarcher
force-pushed
the
dev-server-index-help
branch
from
July 4, 2022 06:14
deb9374
to
4d386d8
Compare
timacdonald
approved these changes
Jul 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely gorgeous solution 🤩 Tested and working great on my end.
timacdonald
reviewed
Jul 4, 2022
Co-authored-by: Tim MacDonald <hello@timacdonald.me>
jessarcher
force-pushed
the
dev-server-index-help
branch
from
July 5, 2022 03:00
18b7fb3
to
e069a20
Compare
This was referenced Jul 10, 2022
timacdonald
added a commit
that referenced
this pull request
Jul 14, 2022
* Help users that visit the Vite dev server directly * send 404 response status * Update console wording Co-authored-by: Tim MacDonald <hello@timacdonald.me> * Formatting * Update dev-server-index.html Co-authored-by: Tim MacDonald <hello@timacdonald.me> Co-authored-by: Taylor Otwell <taylor@laravel.com>
ElMassimo
added a commit
to ElMassimo/vite_ruby
that referenced
this pull request
Mar 16, 2023
ElMassimo
added a commit
to ElMassimo/vite_ruby
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to help developers that visit the Vite dev server directly by following the link that Vite outputs to the console.
It injects content into the
index.html
page that Vite serves and outputs a warning to the console.Console
Note: this only appears when the index.html page is requested
Browser (light mode)
Browser (dark mode)
Using
APP_URL
is a little problematic as it's not guaranteed to be correct. I'm hoping it's better than nothing though.Fixes #40