[0.6.x] Do not inline small assets, by default #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
approved these changes
Aug 28, 2022
|
As it will change existing functionality from under the user, i.e. 4kb assets will now be in the build dir. I'm happy to see it as a feature rather than a breaking if you think that would be better. |
|
I see it as a bug fix for a new Laravel feature |
timacdonald
changed the title
|
Sounds good to me. We bumped to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Vite will "inline" assets that are smaller than 4kb by base64 encoding them.
From a Laravel perspective this can cause issues for Blade apps that are looking to use the
Vite::asset()helper on small assets.Blade specific apps could set this to
0manually, however I also find the inconsistent behaviour as the default strange - even if it is beneficial to SPA style applications. I feel setting this to0is a good default for Laravel, while still respecting the user configured value.The alternative would be to add some magic into the
assethelper, but I don't think we can generally assume the file will still be in it's pre-bundled location (e.g. resources/images/pixel.png) as apps may clear that stuff out for space reasons (e.g. Serverless).Encoding at runtime also kinda sucks as well - and the inconsistency in the returned result is a little weird (plain URL vs base64 url).
I think if this is something the community wants we could add an additional function
assetOrEncoded()or something along those lines. But I think we can punt that down the road for now.